Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.13 and drop EOL 3.8 #3435

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Add support for Python 3.13 and drop EOL 3.8 #3435

merged 3 commits into from
Dec 22, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 21, 2024

Pull Request Checklist

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

Python 3.13 was released in October, and on the same day Python 3.8 reached end-of-life:

pauloxnet
pauloxnet approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

justinmayer
justinmayer approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Hugo. Thank you for this enhancement. Much appreciated! 🥇

@justinmayer justinmayer merged commit a17521b into getpelican:main Dec 22, 2024
18 checks passed
@hugovk hugovk deleted the add-3.13 branch December 22, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmayer justinmayer justinmayer approved these changes

@pauloxnet pauloxnet pauloxnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @pauloxnet @justinmayer